Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action should report broken references #18

Open
fingolfin opened this issue Sep 23, 2022 · 0 comments
Open

This action should report broken references #18

fingolfin opened this issue Sep 23, 2022 · 0 comments

Comments

@fingolfin
Copy link
Member

fingolfin commented Sep 23, 2022

Looking at e.g. this log I see messages like this:

#I Second run through document . . .
#W WARNING: non resolved reference: rec(
  BookName := "ref",
  Oper := "ViewObj" )
#W WARNING: non resolved reference: rec(
  BookName := "ref",
  Oper := "PrintObj" )

The cause of this is discussed in issue #17, but what I want to focus on here is that the CI job still is reported as successful, and only by drilling into the CI logs does one notice this problem.

I think that at the very least, developers should be notified about this. Perhaps by making the build fail. Or perhaps by showing a "warning message" in the CI -- or perhaps both?

For this we need a way to extract these warnings from the output. Then it is easy to generate GitHub "warning messages" (see here for an explanation what this) which in turn make it easy to get to the exact spot in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant