Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal more appropriately with NO_COVERAGE: turn it into a documented input #6

Open
wilfwilson opened this issue Jan 28, 2022 · 0 comments

Comments

@wilfwilson
Copy link
Contributor

In practice, compiled packages are always compiled with --coverage flags, because the environment variable NO_COVERAGE is unlikely to have been set by a user, even if that's what they want:

build-pkg/action.yml

Lines 21 to 25 in 3246f13

if [[ -z $NO_COVERAGE ]]; then
export CFLAGS="$CFLAGS --coverage"
export CXXFLAGS="$CXXFLAGS --coverage"
export LDFLAGS="$LDFLAGS --coverage"
fi

Therefore, NO_COVERAGE should be made into an input to this Action, as it is in https://github.com/gap-actions/setup-gap. It should also be clearly documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant