Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test compiling packages? #5

Open
fingolfin opened this issue Feb 23, 2022 · 1 comment
Open

Also test compiling packages? #5

fingolfin opened this issue Feb 23, 2022 · 1 comment

Comments

@fingolfin
Copy link
Member

For packages that contain a configure script, perhaps we can also test compiling them (again): because that might fail, too, in interesting ways, e.g. caused by a change in the GAP kernel.

Right now, I believe compilation is done when the GAP Docker container is built, which is fine and useful (when testing package A, it's good to be able to assume that all other packages were built already).

But in general, it means that compile issues are not visible to the GAP team.

@wilfwilson
Copy link
Contributor

Yes.

Is there an easy way of detecting which packages require/offer compilation? Looking for a Makefile helps, but some packages have a Makefile just to compile their manuals (we should not try to 'compile' such packages).

A workflow could download the relevant GAP container, dynamically detect which ones can be compiled, and then constructs a matrix containing only those packages. It would then run a subsequent job using this matrix, which runs the necessary tests (re-compilation, probably followed by an attempt to load the package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants