Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LoadKernelExtension #123

Closed
limakzi opened this issue Aug 26, 2024 · 4 comments
Closed

Implement LoadKernelExtension #123

limakzi opened this issue Aug 26, 2024 · 4 comments

Comments

@limakzi
Copy link

limakzi commented Aug 26, 2024

Be so kind and implement LoadKernelExtension("", "") methods, so it can be aligned with GAP-4.12.

gap-system/gap#5761

@fingolfin
Copy link
Member

I am not sure LoadKernelExtension is really appropriate for the usecase in hap...

@limakzi
Copy link
Author

limakzi commented Aug 28, 2024

For sure, modules are loaded.
https://github.com/gap-packages/hap/blob/master/read.g#L44

@fingolfin
Copy link
Member

I know, but these are not usual kernel extension but gac output and not in use by normal users. (Actually I wonder if @grahamknockillaree uses this code at all? Perhaps it could just be removed)

@grahamknockillaree
Copy link
Collaborator

I agree with @fingolfin that, since the modules are only ever created and loaded when the user wants a gac compiled version of Hap, it's maybe not necessary to use LoadKernelExtension and IsKernelExtensionAvailable . A typical user won't use gac. So I propose to close this issue.

I do remember that for a few functions (I think relating to homotopy contractions of pure cubical complexes) the use of gac produced a noticeable speedup. I'll try to identify what kind of speedups can be obtained and consider how worthwhile it is to keep the gac option for Hap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants