Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing CLI args with a mounted operator configuration #970

Open
unmarshall opened this issue Jan 6, 2025 · 0 comments
Open

Replace existing CLI args with a mounted operator configuration #970

unmarshall opened this issue Jan 6, 2025 · 0 comments
Labels
area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension

Comments

@unmarshall
Copy link
Contributor

How to categorize this issue?

/area control-plane
/area usability
/area dev-productivity
/kind enhancement
/kind api-change

What would you like to be added:

Why is this needed:
etcd-druid currently has a lot of CLI args that are individually exposed and needs to be explicity specified when configuring command line arguments in the deployment resource. This creates a challenge to support downgrade when new CLI flags are added to the newer version. One has to explicitly use pflag library and its capability to ignore CLI args that it does not understand.
Having a well defined API type for configuration allows the following:

  • One file where all the operator configuration is visible
  • One can register the scheme and with it one can register the defaulting and validating functions. This ensures that the rest of the code does not have to deal with providing defaults and validate it at different places.

This is a general pattern that has also been seen in both gardener and other k8s community projects.

@shreyas-s-rao shreyas-s-rao added area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants