Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing classname escaping #179

Open
Nek- opened this issue Jun 7, 2023 · 1 comment
Open

Missing classname escaping #179

Nek- opened this issue Jun 7, 2023 · 1 comment

Comments

@Nek-
Copy link

Nek- commented Jun 7, 2023

We tried to move a massive project to TSS but hit mostly one issue: generated class names may contain parenthesis -someComponent(something)-.

For example, we are exporting this kind of thing:

export default connect(
    mapStateToProps,
    mapDispatchToProps
)(withStyles(sidebarStyle)(injectIntl(Sidebar)));

The injectIntl() ends up in the class name (for us it generates things like css-1hj7v7-injectIntl(Sidebar)-drawerRootContainer), which was the case with JSS as well, but JSS was escaping the class name in CSS: css-1hj7v7-injectIntl\(Sidebar\)-drawerRootContainer.

TSS does not escape the class name, so the browser cannot read the associated CSS rules. This seems to be a severe issue for class components.

@garronej
Copy link
Owner

garronej commented Jun 7, 2023

Hello @Nek-,

Thank you for bringing this issue to our attention.

To enable us to expedite a resolution, it would be tremendously helpful if you could create a replication repository. With this information at hand, we should be well-equipped to develop and deploy a new version promptly.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants