Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop YAML config support for mod profile #18

Open
vswarte opened this issue Jul 21, 2024 · 2 comments
Open

Drop YAML config support for mod profile #18

vswarte opened this issue Jul 21, 2024 · 2 comments

Comments

@vswarte
Copy link
Contributor

vswarte commented Jul 21, 2024

We've just added TOML and made it the default in the match, however I feel like we should consider dropping YAML entirely. Atleast for the time being.

Randomizer mods, for example, might want to parse the mod profile to offer additional support for other mods.
I feel like in the end we want to move this use-case to a dedicated API somehow, but on the short term it means they will have to add YAML support to their parsing procedure etc,

I also personally feel that supporting both formats will result in noise on the troubleshooting as well.

To top it all off, adding it back should be a backwards compatible change. (Later down the line when we have better facilities for mod detection).

@vswarte
Copy link
Contributor Author

vswarte commented Jul 21, 2024

After a quick talk we've decided to immediately head for the correct solution which comes down to us parsing the config and offering a stable API for mod discovery.

@garyttierney
Copy link
Owner

Note: the real problem we're trying to solve here is allowing downstream "Launcher" programs to generate a mod profile. TOML support is not very widespread in other ecosystems (notably .NET), and something like YAML or JSON is easier to interop with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants