Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist feature? #4

Open
martin-braun opened this issue May 11, 2023 · 4 comments
Open

Whitelist feature? #4

martin-braun opened this issue May 11, 2023 · 4 comments

Comments

@martin-braun
Copy link

martin-braun commented May 11, 2023

The idea of this extension is not bad, but it lacks a whitelist feature. The extension prevents https://appstoreconnect.apple.com/login from loading. Please fix, thanks.

Or will tab exceptions perhaps be remembered, already? I'm not sure.

@garywill
Copy link
Owner

There is only hard-coded whitelist currently

var whitelist = [
"gitlab.com",
[ "taobao.com", "alipay.com", "tmall.com", "alibabagroup.com", "aliexpress.com", "alibaba.com", "1688.com", "alimama.com" ],
["szlcsc.com", "lceda.cn", "jlcsmt.com", "oshwhub.com" ],
["cnki.net", "edu.cn", "szlib.org.cn", "zjlib.cn", "library.hb.cn", "gxlib.org.cn"],
];

User whitelist not implemented yet.

The url you posted seems require Apple developer account. I don't have one.
You can send a PR to me to add the urls you need

@martin-braun
Copy link
Author

You don't need an Apple developer account to replicate. It's the login form that isn't loading with your extension activated. You should see a spinning loading animation instead of a login form, until you disable your extension.

I've seen your whitelist. It would be very useful to have user whitelist, so things can be tested out.

@martin-braun
Copy link
Author

#5

But the issue remains, as we would benefit from a user whitelist.

@garywill
Copy link
Owner

I tried that website with my apple account. I can't login even if I totally disable Auto Referer ...
Not sure if something else interfering (eg my network)


You can try adding

["apple.com", "cdn-apple.com"]

to your whitelist. apple.com will cover *.apple.com.

Before user whitelist implemented, you can open Auto Referer debug console (about:debugging on firefox. Or Inspect addon on Chrome), change the variable whitelist to test. E.g.:

whitelist.push(["apple.com", "cdn-apple.com"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants