Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETag header is unavailable to the browser for pre-signed requests #667

Closed
twick00 opened this issue Jul 29, 2024 · 1 comment
Closed

ETag header is unavailable to the browser for pre-signed requests #667

twick00 opened this issue Jul 29, 2024 · 1 comment

Comments

@twick00
Copy link

twick00 commented Jul 29, 2024

Although S3Proxy responds with an included ETag header to multipart uploads, this header isn't seen by the browser because S3Proxy doesn't send Access-Control-Expose-Headers: Etag back with the browser.

If s3proxy.cors-allow-origins contains the origin we're replying to, we should include the Access-Control-Expose-Headers: Etag header as well. Same for if s3proxy.cors-allow-all=true is set.

@twick00
Copy link
Author

twick00 commented Jul 30, 2024

@gaul I don't mind contributing to fix this but I could use your guidance on how to best fix it.

This is the simplest way to handle this:
#668

However, we could also include a new S3PROXY_CORS_EXPOSED_HEADER (s3proxy.cors-exposed-headers) property and allow the user to pass in the headers they want to access. I personally only care about ETag but I'm not sure if others might want other headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants