Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statements #7

Open
ankitxjoshi opened this issue Apr 5, 2018 · 6 comments
Open

Remove print statements #7

ankitxjoshi opened this issue Apr 5, 2018 · 6 comments

Comments

@ankitxjoshi
Copy link
Member

A deployment version never has print statements. Make a logger.py and print logs by importing it. The purpose is not to make things easy but to make them understand how things actually happen and how to code in the right way. Refer this: https://docs.python.org/2/library/logging.html

@quepayal quepayal closed this as completed Apr 6, 2018
@ankitxjoshi
Copy link
Member Author

@EUNIX-TRIX why is it closed before solving it completely?

@ankitxjoshi ankitxjoshi reopened this Apr 6, 2018
@quepayal
Copy link

quepayal commented Apr 6, 2018

Can you tell me what more changes I should do.

@ankitxjoshi
Copy link
Member Author

Line 28 main.py. There are more print statements.

@quepayal
Copy link

quepayal commented Apr 6, 2018

Sir , but if I remove it then how would user know what option to choose so I left it as it is .

@ankitxjoshi
Copy link
Member Author

Logging at info level should should be used for this. All other should be done at debug or errror level. I expected you to make a logger.py where one can define various level, something just like https://github.com/MacBox7/torque/blob/master/raspberry-client/logger.js.

@quepayal
Copy link

quepayal commented Apr 7, 2018

Ya , sure sir I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants