Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI checks required #398

Open
chapulina opened this issue Feb 19, 2021 · 7 comments
Open

Make CI checks required #398

chapulina opened this issue Feb 19, 2021 · 7 comments
Assignees

Comments

@chapulina
Copy link
Contributor

chapulina commented Feb 19, 2021

This issue keeps track of which CI checks are marked as required for each branch on each library.

Only build checks are listed here, because checks like DCO are already required for all libraries.

Required checks are those which must be green before merging a PR. The ultimate goal is to have all checks required, but we need to address known flakes and failures before requiring them.

This list is expected to be dynamic, and we may have regressions that force us to unrequire checks when new issues are introduced. For example, upstream changes in homebrew introduced warnings into our ign-common macOS builds, see gazebosim/gz-common#203.

This list only covers release branches that are part of Ignition collections, so it does not cover branches that are still supported because they're Gazebo 9 dependencies.


ign-cmake

All checked
  • Release branches
    • GitHub actions Bionic
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-common

All checked
  • ign-common3
    • GitHub actions Bionic
    • GitHub actions Focal
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • ign-common[4-9]
    • GitHub actions Bionic (option not showing up)
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • gz-common[0-9]
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Noble
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-fuel-tools

ign-gazebo

  • ign-gazebo[0-9]
    • GitHub actions Bionic (flaky tests)
    • GitHub actions Focal (flaky tests)
    • GitHub actions Jammy (flaky tests)
    • Jenkins Homebrew (flaky tests)
    • Jenkins Ubuntu (flaky tests)
    • Jenkins Windows (warnings and tests)
    • ABI checker
  • main
    • GitHub actions Focal (flaky tests)
    • GitHub actions Jammy (flaky tests)
    • Jenkins Homebrew (flaky tests)
    • Jenkins Ubuntu (flaky tests)
    • Jenkins Windows (flaky tests)

ign-gui

ign-launch

  • ign-launch[0-4]
    • GitHub actions Bionic
    • GitHub actions Focal
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • ABI checker
  • ign-launch[5-9]
    • GitHub actions Bionic (option not showing up)
    • GitHub actions Focal
    • GitHub actions Jammy (option not showing up)
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows (warnings and tests)
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy (not setup yet)
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows (warnings and tests)

ign-math

All checked
  • Release branches
    • GitHub actions Bionic
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-msgs

All checked
  • ign-msgs[0-1]
    • GitHub actions Bionic
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • ign-msgs[2-5]
    • GitHub actions Bionic
    • GitHub actions Focal
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • ign-msgs[6-9]
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-physics

ign-plugin

All checked
  • Release branches
    • GitHub actions Bionic
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-rendering

ign-sensors

  • ign-sensors[0-5]
    • GitHub actions Bionic
    • GitHub actions Focal
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • ign-sensors[6-9]
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew (test failures)
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew (test failures)
    • Jenkins Ubuntu
    • Jenkins Windows

ign-tools

All checked
  • Release branches
    • GitHub actions Bionic
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

ign-transport

ign-utils

All checked
  • Release branches
    • GitHub actions Bionic
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker (option not showing up)
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows

sdformat

All checked
  • sdf[0-9]
    • GitHub actions Bionic
    • GitHub actions Focal
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • sdf[0-9][0-9]
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
    • ABI checker
  • main
    • GitHub actions Focal
    • GitHub actions Jammy
    • Jenkins Homebrew
    • Jenkins Ubuntu
    • Jenkins Windows
@chapulina chapulina self-assigned this Feb 19, 2021
@scpeters
Copy link
Contributor

I just checked the boxes to indicate the current configuration of ign-physics

@chapulina
Copy link
Contributor Author

I just checked the boxes to indicate the current configuration of ign-physics

Thanks, I thought I had done it for all of them, but the GitHub UI kept acting wreird

@scpeters
Copy link
Contributor

I think ign-common main on windows is clean and we could mark it as required (cc @mjcarroll )

@mjcarroll
Copy link
Contributor

I think ign-common main on windows is clean and we could mark it as required (cc @mjcarroll )

Good with me.

@chapulina
Copy link
Contributor Author

I removed the Ubuntu Bionic requirement for all main branches and updated the list above.

@chapulina
Copy link
Contributor Author

I just did another pass over all the checks for all libraries and updated their status. I also made sure that Bionic checks are only required up to Fortress, and Jammy checks only from Fortress.

@mjcarroll
Copy link
Contributor

Jenkins Homebrew warning: 'channels' is deprecated

Closed via gazebosim/gz-common#416

@azeey azeey assigned azeey and unassigned chapulina May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants