Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign-tools additional commands should support relocatable install #6

Open
osrf-migration opened this issue Apr 6, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by Silvio Traversaro (Bitbucket: traversaro).


Summary

Currently the .yml files used by downstream projects contains the library_path field that contain an hardcoded location of the ruby script as it is in the build machine, see for example:

--- # Subcommands available inside ignition-transport.
format: 1.0.0
library_name: ignition-msgs
library_version: 1.0.0
library_path: E:/superinstaller/vcpkg/packages/ignition-msgs1_x64-windows/lib/ruby/ignition/cmdmsgs1
commands:
    - msg   : Print information about messages.
---

Ideally, ign-tools it should be able to encode the location of the ruby script relativly to the location of the .yml file.

Motivation

On a Windows system, it may occur that the installation location in the target system is different from the one of the build machine.

Describe alternatives you've considered

Always forcing users to install binary version of ignition libraries in the same prefix.
Alternativly, the .yml could provide some sort of "installation script" that would be run when installing them on a new machine, but in my experience such solution are more error-prone that a pure relocatable package.

Additional context

A nice description of the problem of the relocatable install (but in CMake context) can be found at https://cmake.org/cmake/help/v3.14/manual/cmake-packages.7.html#creating-relocatable-packages .

cc @seanyen-msft

@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


  • changed title from "ign-tools should support relocatable" to "ign-tools additional commands should support relocatable install"

@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


  • Edited issue description* changed kind from "bug" to "enhancement"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants