-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider binaries to implement the functionality offered by gz
#7
Comments
To use executables in
|
we are doing this in gazebosim/gz-transport#216 using the |
Let's close this issue once all libraries have migrated to binaries. |
|
I guess anyone that tried this on Windows know this, but just to record this for future readers: another problem that is present in Windows when using shell such as Command Prompt or Powershell is that bash-based shebangs do not work, so even if |
For historical reference, that was eventually fixed in #73 . |
ign
gz
@azeey I would like to work on this issue! |
As a starting point, I would recommend porting the fix from gazebosim/gz-plugin#131 to other libraries that already have standalone executable commands like gz-transport and gz-launch. If the windows tests just work after that fix, I would say enable them, but if there's a bunch of failures I think it's worth merging the fix to the ruby file on its own. A follow up task could be completing the conversion for What do you think @azeey? |
Original report (archived issue) by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
Right now,
ign
is a ruby script that offers several subcommands (topic, msg, etc.). Each subcommand is implemented by a function inside a versioned Ignition shared library.ign
also keeps track of multiple versions of the same library. This approach has some issues, in particular we have detected:gdb
when runningign
. Imagine for example runningign gazebo …
An idea for mitigating these issues might be to move the functionality from a shared library to a binary (e.g.:
igntopic
). In this case,ign
should invoke the right external binary. The solution to (1) is to run gdb with the binary directly without usingign
. (2) probably won’t happen again as we wouldn’t need to interact with a shared library anymore, just executing an external binary which looks less involved.On the other hand, each Ignition library should do some refactor and expose a binary (or a collection of binaries) that capture all functionality to be executed from the command line.
The text was updated successfully, but these errors were encountered: