Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky failure of INTEGRATION_recorder #235

Open
scpeters opened this issue Mar 31, 2021 · 1 comment
Open

Flaky failure of INTEGRATION_recorder #235

scpeters opened this issue Mar 31, 2021 · 1 comment
Labels
bug Something isn't working tests Broken or missing tests / testing infra

Comments

@scpeters
Copy link
Member

Environment

  • OS Version: Ubuntu 20.04
  • Source or binary build? source build of ign-transport in Focal GitHub action

Description

  • Expected behavior: test passes
  • Actual behavior: test failed

Steps to reproduce

  1. Build from source
  2. Run INTEGRAITON_recorder many times
  3. See how often it fails

Output

See #216 (comment) referring to the following action:

[ RUN      ] recorder.BeginRecordingTopicsAfterAdvertisement
  Chirping [1500] times on [2] topics:
   -- /foo
   -- /bar
  /github/workspace/log/test/integration/recorder.cc:206: Failure
  Expected equality of these values:
    numChirps
      Which is: 1500
    protoMsg.data()
      Which is: 1499
  [  FAILED  ] recorder.BeginRecordingTopicsAfterAdvertisement (3801 ms)
@scpeters scpeters added the bug Something isn't working label Mar 31, 2021
@chapulina chapulina added the tests Broken or missing tests / testing infra label Apr 12, 2021
@scpeters
Copy link
Member Author

I just observed a flaky failure on an 18.04 GitHub action:

[ RUN      ] recorder.BeginRecordingAllBeforeAdvertisement
Chirping [100] times on [4] topics:
 -- /foo1
 -- /foo2
 -- /bar1
 -- /bar2
/github/workspace/log/test/integration/recorder.cc:264: Failure
Expected equality of these values:
  numChirps*numMatchingTopics
    Which is: 400
  count
    Which is: 396
[  FAILED  ] recorder.BeginRecordingAllBeforeAdvertisement (2201 ms)
...
 [==========] 9 tests from 1 test case ran. (14475 ms total)
  [  PASSED  ] 8 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] recorder.BeginRecordingAllBeforeAdvertisement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Broken or missing tests / testing infra
Projects
None yet
Development

No branches or pull requests

2 participants