Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y2Dmg Emulator #180

Open
leefogg opened this issue Jun 4, 2020 · 8 comments
Open

Y2Dmg Emulator #180

leefogg opened this issue Jun 4, 2020 · 8 comments
Labels
remove Deprecated, old or incomplete resources you don't think deserve to be listed as awesome

Comments

@leefogg
Copy link

leefogg commented Jun 4, 2020

Description notes that the emulator passes (all) of Blarggs test roms, it however only passes a couple. From the comments left in DmgSystem.cs, only 15 roms were tested out of the total 46.
Until we have a method of quantifiably measuring any particular emulator's accuracy (with a number for instance), I think we should avoid qualitative descriptions.
Only raising this as an issue as many devs are looking for a readable accurate emulator (including myself) and we shouldn't waste their time.

@avivace
Copy link
Member

avivace commented Jun 8, 2020

Hi @leefogg and thanks for the feedback.

At the moment, the EMULATORS.md does not require any minimum level of "quality" of the contents it lists, while the Emulators chapter in the main list provides a more accurate selection.

Should we try to outline some kind of criteria that resources have to satisfy to be on the EMULATORS.md list?

@avivace avivace added the remove Deprecated, old or incomplete resources you don't think deserve to be listed as awesome label Jun 8, 2020
@leefogg
Copy link
Author

leefogg commented Jun 9, 2020

I think simple QC on it will do like:

  1. It builds.
  2. It runs {some popular game}
  3. It's description is truthful

@avivace
Copy link
Member

avivace commented Jun 9, 2020

How can you define "truthful"? Are we gonna check every documentation file and run tests on the proposed emulator?

@leefogg
Copy link
Author

leefogg commented Jun 9, 2020

If they mention they pass x tests, we'll have to prove that yes. Its only to stop proposals like "runs every game perfectly" from slipping in.

@avivace
Copy link
Member

avivace commented Jun 10, 2020

Nothing "runs every game perfectly", apart from the Game Boy itself, so that kind of proposal is excluded anyway.
IMO we have to rethink about that list, and decide if we want to keep it as inclusive, or move to a more curated (similar to the main list) resource, providing examples of implementation for different frameworks and languages.

@ISSOtm
Copy link
Member

ISSOtm commented Feb 9, 2021

I think curating the list would be more useful- given the purposes outlined above. That said, given this and the list's size, wouldn't it be more relevant to make a separate "awesome-gbemu"/"awesome-gbemudev" list?

@avivace
Copy link
Member

avivace commented Feb 9, 2021

Why? What's the advantage of fragmenting something that has the same scope (curated list of resources related to gb/gbdev)? Can't we outline a process for different kind of resource in the same repositories?

@ISSOtm
Copy link
Member

ISSOtm commented Feb 9, 2021

GBDev and GBEmuDev actually have little interaction. Taking the Discord as an example, I see few users in both #emudev and other channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove Deprecated, old or incomplete resources you don't think deserve to be listed as awesome
Projects
None yet
Development

No branches or pull requests

3 participants