-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Period changes take" in Audio_registers.md - NR13 paragraph #491
Comments
I think it's meant to say "Period changes take effect only when the previous period next expires"; cc @LIJI32 to confirm that that's right. Also, not sure that formulation is super clear. |
Yes, that's correct. |
Alright, now to find a way to phrase it that makes sense not just in retrospect. |
I wrote this in #334:
Does that sound clear? If so, then it can be used as a base for the new explanation. |
To me, both sound pretty clear! |
I'm afraid of the first one only making sense "in retrospect", i.e. if you already understand what "when the period expires" means—it's really talking about the counter used to implement that period. Regardless, it turns out that the explanation was already added in #486, so maybe a warning-type box reading "writes to this register may not take effect immediately, see the next paragraph for more details" would do the trick? |
Hello,
It seams there is an unfinished sentence at the end of the paragraph NR13, it is only written "Period changes take".
The text was updated successfully, but these errors were encountered: