Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Period changes take" in Audio_registers.md - NR13 paragraph #491

Closed
marcie1000 opened this issue Jun 25, 2023 · 6 comments · Fixed by #505
Closed

"Period changes take" in Audio_registers.md - NR13 paragraph #491

marcie1000 opened this issue Jun 25, 2023 · 6 comments · Fixed by #505

Comments

@marcie1000
Copy link

Hello,

It seams there is an unfinished sentence at the end of the paragraph NR13, it is only written "Period changes take".

@ISSOtm
Copy link
Member

ISSOtm commented Jun 25, 2023

I think it's meant to say "Period changes take effect only when the previous period next expires"; cc @LIJI32 to confirm that that's right.

Also, not sure that formulation is super clear.

@LIJI32
Copy link
Member

LIJI32 commented Jun 25, 2023

Yes, that's correct.

@ISSOtm
Copy link
Member

ISSOtm commented Jun 26, 2023

Alright, now to find a way to phrase it that makes sense not just in retrospect.

@ISSOtm
Copy link
Member

ISSOtm commented Jul 2, 2023

I wrote this in #334:

Note that the value written to this field is not re-read by the hardware until a sweep iteration completes, or the channel is (re)triggered.

Does that sound clear? If so, then it can be used as a base for the new explanation.

@marcie1000
Copy link
Author

I think it's meant to say "Period changes take effect only when the previous period next expires"; cc @LIJI32 to confirm that that's right.

Also, not sure that formulation is super clear.

I wrote this in #334:

Note that the value written to this field is not re-read by the hardware until a sweep iteration completes, or the channel is (re)triggered.

Does that sound clear? If so, then it can be used as a base for the new explanation.

To me, both sound pretty clear!

@ISSOtm
Copy link
Member

ISSOtm commented Jul 2, 2023

I'm afraid of the first one only making sense "in retrospect", i.e. if you already understand what "when the period expires" means—it's really talking about the counter used to implement that period.

Regardless, it turns out that the explanation was already added in #486, so maybe a warning-type box reading "writes to this register may not take effect immediately, see the next paragraph for more details" would do the trick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants