Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with DDC notations in ConceptScheme #41

Open
2 tasks
stefandesu opened this issue Jan 26, 2024 · 0 comments
Open
2 tasks

Issues with DDC notations in ConceptScheme #41

stefandesu opened this issue Jan 26, 2024 · 0 comments

Comments

@stefandesu
Copy link
Member

Given the following instance of ConceptScheme:

const ddc = new ConceptScheme({
    uri: "http://dewey.info/scheme/edition/e23/",
    uriPattern: "^http://dewey.info/class/(.+)/e23/$",
    notationPattern: "(([0-9][0-9]?|[0-9]{3}(-[0-9]{3})?|[0-9]{3}\\.[0-9]+(-[0-9]{3}\\.[0-9]+(:[0-9]+)?)?|T[1-9][A-Z]?--[0-9]+(-T[1-9][A-Z]?--[0-9]+(:[0-9]+)?)?|[1-9][A-Z]?--[0-9]+(-[1-9][A-Z]?--[0-9]+(:[0-9]+)?)?)?)",
  })

The following case causes issues:

ddc.uriFromNotation("T1--0901-T1--0905:07")
  • Currently in jskos-tools v1.0.34, the resulting URI and notation both encode the : even though it shouldn't be encoded (this is a regression in v1.0.34 in particular)
  • In our data (e.g. in Cocoda), we are using a short form of that notation in the URI: http://dewey.info/class/1--0901-0905:07/e23/. If we wanted jskos-tools to generate correct URIs, we would need to add special handling for DDC. However, this is still up to discussion, see DDC: Decide how to deal with table range notations jskos-data#47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant