Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate changes to FederatedStoreCache.java #3170

Open
GCHQDeveloper314 opened this issue Mar 13, 2024 · 0 comments
Open

Investigate changes to FederatedStoreCache.java #3170

GCHQDeveloper314 opened this issue Mar 13, 2024 · 0 comments
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Milestone
Medium Term Backlog

Comments

@GCHQDeveloper314
Copy link
Member

Prior to #3147, FederatedStoreCache.java was inheriting from Cache.java solely to enforce some generics. It had various overriding methods which were unused but were left in place in that PR.

Either this inheritance should be put back, another way to fix the generics found or this class and FederatedStoreCacheTransient.java refactored to simplify them.
@GCHQDeveloper314 GCHQDeveloper314 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Mar 13, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the Medium Term Backlog milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Milestone
Medium Term Backlog
Development

No branches or pull requests
1 participant
@GCHQDeveloper314