-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge gcla/tail changes back to maintainer #74
Comments
Hi - interesting, and thanks for the nxadm/tail lead. Maybe I should open an issue and ask if they'd be interested in tailing by bytes rather than by line. The code I hacked in and renamed gcla/tail was pretty cheesy and I'd feel sheepish offering it up as-is though. |
I'm currently trying to upgrade |
I can take care of the merge and cleanup of code at some point. This will likely mean instead of using replacements of bytes for strings, parallel methods are used. |
Hi @dawidd6 - quick question for you. The tail fork package is only needed on termshark for Windows because on Linux and friends we can just rely on the familiar tail command being installed. If the uses of gcla/tail were only within Go files that were compiled only on Windows (e.g. |
@gcla yea, using build tags should eliminate the need to package this dependency, since it would be windows only. Good solution! |
@pocc - I opened this issue against |
Cheers |
Just a small note that I haven't forgotten the issue, but that I am busy merging and reviewing the many issues and PRs open on the dormant upstream project. Because nxadm/tail is starting to get some traction (as fas as I can see from git clones and the addition to Fedora/Debian/Ubuntu), I am extra careful not to break stuff :). |
Just cleaning up - please re-open if this would still be useful to have. |
bug report/feature request/ask
gcla/tail can't take issues and I have a couple of thoughts:
The text was updated successfully, but these errors were encountered: