Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace closures with callable structs in second order #315

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 8, 2024

DI source

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.04%. Comparing base (e93d16a) to head (86af6ab).

Files Patch % Lines
DifferentiationInterface/src/second_order/hvp.jl 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   96.08%   96.04%   -0.05%     
==========================================
  Files          95       95              
  Lines        4398     4403       +5     
==========================================
+ Hits         4226     4229       +3     
- Misses        172      174       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Replace v with dx in hvp signature Replace closures with callable structs in second order Jun 8, 2024
@gdalle gdalle merged commit 9fb32cd into main Jun 8, 2024
50 checks passed
@gdalle gdalle deleted the gd/hvp_dx branch June 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants