-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test lower compat bounds on LTS #380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 96.62% 96.58% -0.05%
==========================================
Files 102 102
Lines 4974 4974
==========================================
- Hits 4806 4804 -2
- Misses 168 170 +2 ☔ View full report in Codecov by Sentry. |
I'm not sure whether this action should be called before or after the |
Thanks for this attempt, but see the comment #378 (comment) for why this is bound to fail: the AD backends are not part of the DI test environment, they are added afterwards (and so is DIT). |
I don't think the problem is unfixable, but let's not allow perfection to get into the way of progress: How about reverting the general LTS tests and adding tests on lower compat bounds to |
I think downgrade compat should work once #381 is merged. However I don't see why you would need to remove the precise compat entries that I designed with great care ^^ There is a reason behind most of those, and things will fail if you remove them. |
I guessed this would be the case, but I wanted to see these lower bound tests fail to make sure they are working. ;) |
If you want a surefire check, anything strictly less than SparseMatrixColorings v0.3.4 will error right away in DI because one of the names I use was defined in v0.3.4 |
abe6ae2
to
571eeed
Compare
Another issue is that only a handful of backends get tested on LTS. Ideally we'd wanna run these tests on the stable release of Julia (too). |
Maybe the solution that's least expensive in GitHub-Actions-compute is to test all backends on LTS? |
Looks like this caught an actual bug in SparseMatrixColorings.jl:
EDIT: Opened gdalle/SparseMatrixColorings.jl#32 |
Closes #378.
Uses the
julia-downgrade-compat
on the LTS tests to test on the lower bounds of compat-entries.Note that this PR puts some constraints on future compat entries: