Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neural network tests #490

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Update neural network tests #490

merged 4 commits into from
Sep 24, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 23, 2024

DIT extensions

  • Use the Constant context mechanism for Flux and Lux scenarios.
  • Make Flux scenarios reproducible with rng.
  • Use ForwardDiff instead of FiniteDiff for the reference of Lux scenarios (doesn't work with Flux because of Flux.reset!). Keep ComponentArray on both sides for result comparison.
  • Deactivate Flux scenarios with iterated model application, for some reason they're failing now.

@gdalle gdalle linked an issue Sep 23, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (097930a) to head (ab8f766).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   97.87%   98.30%   +0.43%     
==========================================
  Files         107      107              
  Lines        4322     4311      -11     
==========================================
+ Hits         4230     4238       +8     
+ Misses         92       73      -19     
Flag Coverage Δ
DI 98.31% <ø> (ø)
DIT 98.28% <100.00%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 24, 2024 08:31
@gdalle gdalle merged commit f518a6b into main Sep 24, 2024
116 of 117 checks passed
@gdalle gdalle deleted the gd/lux branch September 24, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Lux v1
2 participants