Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove image doesn't work/update properly #24

Open
scottg2 opened this issue May 1, 2012 · 1 comment
Open

remove image doesn't work/update properly #24

scottg2 opened this issue May 1, 2012 · 1 comment

Comments

@scottg2
Copy link

scottg2 commented May 1, 2012

Using the removeImageAtIndex: method, it removes the image but doesn't update the photo view properly. It just presents a black background - if you then thumb left or right the image indexing seems all messed up (wrong photos come up, doesn't show some). I'm only testing with between five to ten images and only in fullscreen, not using thumbnails at all. I'm loading all images from the files system.

Took a look at the method implementation for removeImageAtIndex and I don't see it doing anything to adjust or check _currentIndex (against the [_photoSource numberOfPhotosForPhotoGallery:self] upper boundary. Also the moveScrollerToCurrentIndexWithAnimation: call from layoutViews: is using the _currentIndex but I couldn't figure out exactly what it was doing with the scroller frame calculations.

@scottg2
Copy link
Author

scottg2 commented May 2, 2012

Work around for this issue is to grab _currentIndex, call reloadGallery, then call goToImageAtIndex:_currentIndex. However, this is less efficient than what the removeImageAtIndex: method is trying to do. I don't notice any performance impact using this work around, with appx. 40 to 50 images in the gallery.

@jetstar89
Copy link

This issue was opened long time ago. Is there any update about this issue FGalarry team? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants