Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing 3D previewer (X_ITE) #68

Open
Cook4986 opened this issue Jun 13, 2024 · 2 comments
Open

Testing 3D previewer (X_ITE) #68

Cook4986 opened this issue Jun 13, 2024 · 2 comments

Comments

@Cook4986
Copy link

Cook4986 commented Jun 13, 2024

@pdurbin Here's a range of HL models with problems that we can use for further 3D previewer testing:

Note: I've confirmed these X3D models are rendering correctly in both Meshlab and Blender (v3.3).

Any ideas about the missing geometry, @PaulBoon? @landreev, would you mind "putting some configuration settings in place on the Dataverse end" to enable .obj and/or .gltf format(s) previewing, to compare (should be supported as per pull request #56)?

@PaulBoon
Copy link

PaulBoon commented Jun 18, 2024

@Cook4986 , @landreev , Sorry for the late reply. When I used the wording 'initial implementation' I was hoping others would pick it up and improve wherever possible.
Without having tried to improve rendering I would like to warn for optimizing on specific models, better make something into a menu option instead of a default. Also it might be impossible to get a previewer that works good for every model you throw at it, so we might have to decide what is good enough or how we can have it 'fail' gracefully.

@PaulBoon
Copy link

PaulBoon commented Jun 18, 2024

@Cook4986 Great examples. Loading takes a long time, at first just a black canvas, then a 'loading 1 file' without much of a progress indication. Not sure what it is, but depending on the angle surfaces seem to vanish, so maybe something goes wrong with the surface normals. Maybe Meshlab can give a clue?

BTW I just opened it in Meshlab and it looks ok, only the bottom part of the book is 'open', makes sense because that was probably occluded when scanning, but at least that is not going wrong in the previewer.
Screenshot from 2024-06-18 17-28-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants