Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monthly endpoint for MetricsAPI #211

Open
3 tasks done
DS-INRA opened this issue Aug 2, 2024 · 1 comment
Open
3 tasks done

Add monthly endpoint for MetricsAPI #211

DS-INRA opened this issue Aug 2, 2024 · 1 comment
Labels
status:incoming Newly created issue to be forwarded type:feature New feature

Comments

@DS-INRA
Copy link

DS-INRA commented Aug 2, 2024

Before we can start

Before moving on, please check some things first:

  • Your issue may already be reported! Please search on the issue tracker before creating one.

None found with "monthly"

  • Is this something you can debug and fix? Send a pull request! For more information, see the Contributor Guide.

Possible but not likely (time needed)

Prerequisites

  • Are you running the latest version?

pyDataverse==0.3.3

Feature Request

Add support for /api/info/metrics/{metric}/monthly in the MetricsAPI class

Question : would it be best to have a series of get_dataset/file/dataverses_by_month() or a more generic function get_metric_by_month() with the type as a parameter ?

@DS-INRA DS-INRA added status:incoming Newly created issue to be forwarded type:feature New feature labels Aug 2, 2024
@JR-1991
Copy link
Member

JR-1991 commented Aug 22, 2024

@DS-INRA, thank you for submitting the feature request! I recommend creating a generic function that uses an Enum to encode the types, as it would be straightforward. I’ve added this to our working group project as a todo item and will handle the PR once other tasks are completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:incoming Newly created issue to be forwarded type:feature New feature
Projects
Development

No branches or pull requests

2 participants