Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdsfactory requirement from ~=8.18.0 to >=8.18,<8.20 #417

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2024

Updates the requirements on gdsfactory to permit the latest version.

Release notes

Sourced from gdsfactory's releases.

v8.19.1

What's Changed

Bug Fixes

  • fix layer or width for bends #3390

Full Changelog: gdsfactory/gdsfactory@v8.19.0...v8.19.1

Changelog

Sourced from gdsfactory's changelog.

8.19.1 - 2024-11-15

  • fix layer or width for bends #3390

8.19.0 - 2024-11-15

  • better netlist names for na/nb/dax/day -> columns/rows/column_pitch/row_pitch #3380
  • Fix text justify #3388
  • Fix port orientation #3386
  • fix array placement #3385
  • fix cutback_component #3384

8.18.2 - 2024-11-14

  • fix bend width #3374
  • add deprecation for ref.parent #3377
  • Cleaner to um conversion #3375
  • better pcell values #3371
  • improve_text_klayout #3370

8.18.1 - 2024-11-11

  • fix missing start/end angles arg in route_bundle #3366
  • Fix route_bundle to allow routing electrical ports like optical ones #3363 #3365
  • Fix test manifest #3361
  • simpler logic #3364
  • Document route dubin #3367
  • add code example in readme #3358
  • NEW ROUTING: Added optimal Dubins paths. #3362
  • Bump kfactory[ipy] from 0.21.6 to 0.21.7 #3359
  • Pin python max version #3357

8.18.0 - 2024-11-10

  • Add sample reticle electrical #3344
  • Enable plot netlists and schematics with graphviz #3333
  • add test for test_write_test_manifest #3340
  • deprecate import_gds_with_conflicts and add pdk.version #3339
  • Improve test manifest #3338
  • Fix add fiber array excluded ports #3355
  • fix graphviz docs #3354
  • get all cells in manifest #3341
  • fix crow by removing hardcoded ring name #3349
  • install graphviz #3348
  • Update watchdog requirement from <6 to <7 #3335

8.17.0 - 2024-10-29

  • update get cells function #3328
  • improve docs after dbu #3325

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Update the gdsfactory dependency version range to allow versions from 8.18 up to, but not including, 8.20.

Updates the requirements on [gdsfactory](https://github.com/gdsfactory/gdsfactory) to permit the latest version.
- [Release notes](https://github.com/gdsfactory/gdsfactory/releases)
- [Changelog](https://github.com/gdsfactory/gdsfactory/blob/main/CHANGELOG.md)
- [Commits](gdsfactory/gdsfactory@v8.18.0...v8.19.1)

---
updated-dependencies:
- dependency-name: gdsfactory
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 18, 2024
Copy link
Contributor

sourcery-ai bot commented Nov 18, 2024

Reviewer's Guide by Sourcery

This PR updates the gdsfactory dependency version constraint in pyproject.toml from ~=8.18.0 to >=8.18,<8.20, allowing compatibility with newer patch and minor versions up to but not including 8.20.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated dependency version constraint for gdsfactory
  • Changed version constraint from ~=8.18.0 (equivalent to >=8.18.0,<8.19.0) to >=8.18,<8.20
  • Allows compatibility with newer versions including 8.19.x releases
  • Maintains backward compatibility by keeping the lower bound at 8.18
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 22, 2024

Superseded by #418.

@dependabot dependabot bot closed this Nov 22, 2024
@dependabot dependabot bot deleted the dependabot/pip/gdsfactory-gte-8.18-and-lt-8.20 branch November 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants