Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider protecting master #160

Open
cmungall opened this issue Apr 3, 2019 · 6 comments
Open

Consider protecting master #160

cmungall opened this issue Apr 3, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cmungall
Copy link
Member

cmungall commented Apr 3, 2019

On: https://github.com/geneontology/geneontology.github.io/settings/branches

This would allow a wider circle to edit and a smaller trusted circle to approve

Potential downside? Would this make it harder to have auto-commits via pipeline? @lpalbou @kltm

@kltm
Copy link
Member

kltm commented Apr 3, 2019

@cmungall there is some whitelisting mechanism. If we decided to go this route, I'm sure we could have a workaround.
That said, how many rogue committers are we really expecting?

@cmungall
Copy link
Member Author

cmungall commented Apr 3, 2019 via email

@suzialeksander suzialeksander added the enhancement New feature or request label Jul 9, 2019
@suzialeksander
Copy link
Collaborator

I think protecting master is the right step, @lpalbou @kltm thoughts? But in response to @kltm not too many rogues have touched the site so far, so this may not be of the highest importance.

@kltm
Copy link
Member

kltm commented Nov 4, 2024

Okay, I did the following:

  • using "classic" branch protection rules
  • require a PR
    • require at least one approval to merge
    • people in geneontology/admin can bypass this
  • Require status checks to pass before merging
  • Require branches to be up-to-date before merging

Any other thoughts for this one?

@kltm kltm moved this from To do to Clearing in GO website improvements Nov 4, 2024
@kltm kltm self-assigned this Nov 4, 2024
@kltm
Copy link
Member

kltm commented Nov 4, 2024

Tagging @pgaudet @suzialeksander

@pgaudet
Copy link
Collaborator

pgaudet commented Nov 5, 2024

This works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Clearing
Development

No branches or pull requests

4 participants