New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If restrictions are an empty string, allow any mime type? #271

Open

jpfeuffer opened this issue Feb 7, 2020 · 0 comments

Member

jpfeuffer commented Feb 7, 2020

currently this fails because "" != "mzML" for example.
https://github.com/genericworkflownodes/GenericKnimeNodes/blob/develop/com.genericworkflownodes.knime/src/com/genericworkflownodes/knime/generic_node/GenericKnimeNodeModel.java#L538

Advantage:
This should closer to what one would think it would do.

Disadvantage:
Harder to find errors, where someone just forgot to set a mime type and then the nodes fail at runtime instead of construction time.

Alternative:
Introduce "*" or a placeholder for "any mime type".

Related to #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment