Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Detection Easily Broken #16

Open
sargun opened this issue Feb 15, 2019 · 1 comment · May be fixed by #19
Open

Docker Detection Easily Broken #16

sargun opened this issue Feb 15, 2019 · 1 comment · May be fixed by #19

Comments

@sargun
Copy link

sargun commented Feb 15, 2019

It appears like Docker detection happens by inspecting /proc/1/cgroup. If the cgroup paths themselves don't include "docker", then the detection fails. This happens if the user decides to control / configure the cgroup path.

I think there may be a couple other heuristics that we can use. Some other options:

  • look for /.dockerenv
  • look for /.dockerinit
This was referenced May 7, 2021
Closed
Open
@Silvanoc
Copy link

Silvanoc commented Aug 31, 2021 •
edited
Loading

Please read GoogleContainerTools/kaniko#1686 (comment). The proposed and implemented heuristic has its issues... Just a heads-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve container detection using container specific files ejose19/bpfd
2 participants
@sargun @Silvanoc