Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is not triggered for pull requests #325

Open
AkihiroSuda opened this issue Jan 14, 2021 · 1 comment
Open

CI is not triggered for pull requests #325

AkihiroSuda opened this issue Jan 14, 2021 · 1 comment
Labels
bug exp/beginner low hanging fruit

Comments

@AkihiroSuda
Copy link
Collaborator

We should enable CI for pull requests as well

@AkihiroSuda AkihiroSuda added bug exp/beginner low hanging fruit labels Jan 14, 2021
@nathanblair
Copy link

Hi @AkihiroSuda !

I would love to take a shot at this but would like to know more about the desired behaviors.

To narrow it down:

  • Are you wanting all PRs against just the default shared branch (master, in this case)? Or every PR against every branch in the repository?
    • I'm not sure what the project expects for maintaining multiple branches on this repo, so just want to check. Currently there is only one other branch existing.
  • Which workflows exactly do you have in mind to run on PRs? Just the make-all workflow? Or should make-image also be included?
  • Presumably the code that is built should be the code on the head branch?
    • I'm sure this sounds like a silly question but I don't like to assume anything if I can help it!

@nathanblair nathanblair mentioned this issue Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug exp/beginner low hanging fruit
Projects
None yet
Development

No branches or pull requests

2 participants