Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-ascii characters in the GeoArrowTextLayer #62

Open
kylebarron opened this issue Nov 3, 2023 · 1 comment
Open

Support non-ascii characters in the GeoArrowTextLayer #62

kylebarron opened this issue Nov 3, 2023 · 1 comment

Comments

@kylebarron
Copy link
Member

For first implementation, just validate that string is ascii. Check that all byte values are <128.

For future implementation, we'll have to convert utf-8 to utf-16
@kylebarron kylebarron changed the title GeoArrowTextLayer Support non-ascii characters in the GeoArrowTextLayer Nov 8, 2023
@kylebarron
Copy link
Member Author

kylebarron commented Nov 8, 2023 •
edited
Loading

Initial implementation (without even ascii validation was added in #70 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylebarron