-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nearest neighbour function #20
Comments
Hi @patricoferris, I would love to work on this issue. Is there any documentation pertaining to the nearest neighbor function of what it should do or should I just check the code in Go/Rust and try to mimic it in Ocaml? |
It can be a good approach to go through the Rust implementation :) |
Nope :( I didn't find any, I have been preoccupied with some other work recently, and I had expected the project mentors to provide me with the resources. I'll look up the resources and see what I can find. |
Hi @patricoferris, do we want to calculate the nearest neighbor from a point specifically to our values (leaf nodes)? My question is where do I keep the distance functions? Should it be inside of module V or should I create a module called Point? |
Good question @kushalpokharel , for now let's start with a dedicated |
It seems very common for Rtree implementations to provide a
nearest_neighbour
function, so we should do the same! A few examples from other Rtree (or related) libraries.The Go one makes reference to http://www.cs.ucr.edu/~ravi/CS236Papers/roussopoulosNN95.pdf
This is quite involved so do have a look for other
good first issue
s if you haven't made a contribution yet unless you feel comfortable. And do ask questions!The text was updated successfully, but these errors were encountered: