You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is duplicate code for creating auxiliary, diagnostic, and derived fields. We can refactor the code to eliminate the duplication.
Desired Solution
The various implementations of the Physics object call addXXX for each subfield.
Move createXXXField() methods to the Physics abstract base class.
The various implementation of the Physics object also hold just one discretizations map. When adding a subfield, the physics object passes the discretization to the factory.
Factories would need to hold an array of (subfieldName, description, discretization).
Might be able to use template methods to reduce code duplication across IntegratorDomain, IntegratorInterface, and IntegratorBoundary.
Set default discretization via Pyre settings.
The text was updated successfully, but these errors were encountered:
Description
There is duplicate code for creating auxiliary, diagnostic, and derived fields. We can refactor the code to eliminate the duplication.
Desired Solution
Physics
object calladdXXX
for each subfield.createXXXField()
methods to thePhysics
abstract base class.Physics
object also hold just one discretizations map. When adding a subfield, the physics object passes the discretization to the factory.IntegratorDomain
,IntegratorInterface
, andIntegratorBoundary
.The text was updated successfully, but these errors were encountered: