Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event OpenGraph metadata #42

Open
samwilson opened this issue Jun 22, 2023 · 4 comments
Open

Improve event OpenGraph metadata #42

samwilson opened this issue Jun 22, 2023 · 4 comments

Comments

@samwilson
Copy link
Member

Doesn't make good preview cards at the moment, e.g. https://www.opengraph.xyz/url/https%3A%2F%2Fgeogeeks.org%2F2023%2F0705_qfield-osm.html

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Jun 23, 2023

I don't think this is limited to events. The home site doesn't have good og metadata either https://www.opengraph.xyz/url/https%3A%2F%2Fgeogeeks.org%2F. Happy to work on this PR (mainly preview image and description), I'll assume for now just site-wide OG metadata.

At the moment, the description is taken from the description metadata entry for pages, which isn't set for any of the pages at the moment.

<meta name="description" content="{{page.description}}" />

I'll change this to dynamically pull from _data/masthead.yml:description rather than be page specific

I'll also look at making the geogeeks logo the preview thumbnail.

@samwilson
Copy link
Member Author

Thanks! That sounds great. description used to be set, but it was the full text of the event and so probably not the best for OG anyway. Perhaps for events we could just have a static description for now, e.g. "An event run by Geogeeks in Western Australia." or something simple, maybe with the date thrown in too.

We have a generic description here as well, that might be good for the homepage: https://github.com/osmlab/osm-community-index/blob/main/resources/oceania/australia/geogeeks_perth.json

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Jun 23, 2023

Hmm. Did some looking and couldn't find a way that the description can be set in events.html. Looks like jekyll only looks to the front matter for the page, and can't access the front matter from the layouts. Maybe set the description for all the events pages, and we can have a sitewide if not page.description -> fallback?

Its a bit manual, but that would probably be the easiest way to do page specific og descriptions

@BudgieInWA
Copy link
Contributor

I like using the beginning of the event text for a short description. I have been composing the the event descriptions on OsmCal with that in mind, so the snippet shown when the link is posted in slack looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants