Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase API limits for active users #1053

Open
okainov opened this issue Aug 28, 2024 · 2 comments
Open

Increase API limits for active users #1053

okainov opened this issue Aug 28, 2024 · 2 comments
Labels
-hard- Difficulty to fix: hard enhancement New feature or request _LOW Low: Not user blocking

Comments

@okainov
Copy link
Member

okainov commented Aug 28, 2024

From #941

aybe add some "tiers", so users who are active/old/have some GK in inventory get bigger API limit? While anonymous or newbies get default one (which can be even less than 1500). I would imagine that if the limit is bigger than, let's say 50*(amount of GKs in inventory), it should be quite fine even with most active folks (I think if you check profiles of the users already posted here, you'll see that they have hundreds of GKs in their hands if not thousand)

@SDymon
Copy link

SDymon commented Aug 28, 2024

I would appreciate it if you would inform us about the implementation of such a possibility here. It is extremely inconvenient to calculate the daily limit and mark GK taking into account the existing limit!

@kumy kumy added enhancement New feature or request _LOW Low: Not user blocking -hard- Difficulty to fix: hard labels Aug 28, 2024
@kumy
Copy link
Member

kumy commented Aug 28, 2024

This is not an easy issue. Will take time to think about it and implement properly. The ratelimit system doesn t use the postgres db itself, but work with redis and http requests. Thus preserving system resources.

(Also I will take some vacations and won't be there for support if anything goes wrong because of a new feature e.g. #1151)

I have to admit I also have concerns about such way of "playing". Looks like some players are mostly mass creating GK, rarely dropping them and dip every time - to have a high stat counter? Where is the interaction with other players? Goal is to share objects, having them going for cache to cache and players' hands to other hands... Yearly badges are impacted by this. This is also something we should rethink [in another issue] - I already created new badges to reward the "droppers" - I had many complaints about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-hard- Difficulty to fix: hard enhancement New feature or request _LOW Low: Not user blocking
Projects
None yet
Development

No branches or pull requests

4 participants
@kumy @okainov @SDymon and others