-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation search/replace glitches after mkdocs transition #7666
Comments
@davidblasby this is an alarming find, we may need to check if the issue is widespread. |
The GN documentation looks a bit messed up - someone was asking about some OIDC stuff. I see: Notice the text that highlighted are only 2 characters long. However, going here - ... Which looks correct (full names) |
So it appears to be character literals not matching well - and only collecting the last two characters. I hope it is not all through the documentation. |
I think this issue might be quite widespread- I've just found another example in https://docs.geonetwork-opensource.org/4.2/install-guide/configuring-database/#configuring-a-database-via-environment. What would be the best approach to fix- do each one as identified? (If so is it now just a question of fixing the affected markdown file?) |
I forwarded your email to jody garnett - he is looking into it.
dave
|
Oh thanks @archaeogeek - I am a bit disheartened by this feedback being caught so late in the game. The symptom seems to be characters:
That is a string literal that ends up with only two characters.
|
So what is the answer?
I guess I need to "reconvert 32 pages and make a pull-request. |
@jodygarnett I'm happy to manually change any that I find, if that helps |
@archaeogeek / @MichelGabriel this is a small enough list to handle one at a time by comparing:
I have started a branch here: https://github.com/geonetwork/core-geonetwork/tree/docs-glitch If you have capacity to assist it would be timely. |
Fixed the errors in docs/manual/docs/administrator-guide/managing-users-and-groups/authentication-mode.md |
Thanks @MichelGabriel and @archaeogeek for working on this, I created a pull request #7687 with a checklist of each file to be fixed. |
….2 and tutorials/deployment/index
Folks I am having a terrible time with GitHub and managing @archaeogeek pull-requests. I am sorry @archaeogeek I merged #7687 because you were not using it. And then I noticed that your pull-requests, were against that other docs-glitch branch, which was just deleted, so now your pull-requests are broken. I am going to try and restore that branch, but yeah this is a struggle to work together. What am I missing? How does core-geonetwork community work on an activity together? |
Okay @archaeogeek I have managed to recover all your commits. Two files have things outstanding:
|
…ersion-4.0.2 and tutorials/deployment/index
…ion-mode Signed-off-by: Jody Garnett <[email protected]>
….2 and tutorials/deployment/index
Signed-off-by: Jody Garnett <[email protected]>
….2 and tutorials/deployment/index
Signed-off-by: Jody Garnett <[email protected]>
….2 and tutorials/deployment/index
Signed-off-by: Jody Garnett <[email protected]>
This has been addressed for |
Signed-off-by: Jody Garnett <[email protected]>
…ion-mode Signed-off-by: Jody Garnett <[email protected]>
Here is a backport for the 3.12.x branch |
Signed-off-by: Jody Garnett <[email protected]>
Signed-off-by: Jody Garnett <[email protected]>
Describe the bug
Some document glitches have occurred, look to be search and replace problems, during transition to mkdocs
#7286
Additional context
mkdocs: https://docs.geonetwork-opensource.org/4.2/administrator-guide/managing-users-and-groups/authentication-mode/#environment-variable-and-meaning
sphinx: https://github.com/geonetwork/doc/blob/dd1a7a6f2fc7b90f206eaadd1ba6271499a0647c/source/administrator-guide/managing-users-and-groups/authentication-mode.rst#L559
The text was updated successfully, but these errors were encountered: