Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in owner search (2 account looked for while only 1 is allowed) #123

Closed
MaelREBOUX opened this issue May 31, 2021 · 11 comments · Fixed by #171
Closed

Bug in owner search (2 account looked for while only 1 is allowed) #123

MaelREBOUX opened this issue May 31, 2021 · 11 comments · Fixed by #171

Comments

@MaelREBOUX
Copy link
Member

MaelREBOUX commented May 31, 2021

@tdipisa we think we have found a bug that have passed our tests.

Here the steps to reproduce on our test portal :

  1. open cadastrapp
  2. clic sur owner search
  3. search "chauvin frederic"

Here we have the choice to select a suggestion in the list OR to echap the suggestion to show a special window which lists the owners.

The behaviour of the search by the special window is OK.
Choosing "M CHAUVIN FREDERIC" -> 3 parcels
Choosing "M CHAUVIN THOMAS FREDERIC MICHEL" -> 1 parcel

But then : the UI let us choose "M CHAUVIN FREDERIC" directly and if we valid the search we are getting 4 parcels.
So the user believes that this ower has 4 parcels while he owns only 3.

In mapfishapp it cannot happened : if more than 1 owner account is foud we systemacally open the special owner list window and we are obliged to choose one account.

We noted that the mapstore plugin is building a query to /cadastrapp/services/getParcelle with 2 owner account while the user choose only one row in the dropdown list. So here is the origin of 4 parcels while 3 is awaited.

image

Here the current behaviour in mapfishapp

ms2_cadastrapp_bogue_chauvin_mapfishapp

And the problem in mapstore

ms2_cadastrapp_bogue_chauvin_mapstore

@offtherailz
Copy link
Collaborator

offtherailz commented Jun 4, 2021

Ok, I never find out this use case. I hoped that that step could be skipped if I select a user, but I see that there is still ambiguity.
So I created a PR that should solve this issue. Now, even if I select an existing record, if the search returns more than one owner, it will ask for owner selection.

Please check https://github.com/georchestra/mapstore2-cadastrapp/releases/tag/1.0.0-rc13

@tdipisa
Copy link
Collaborator

tdipisa commented Jun 7, 2021

@catmorales, it should be fixed, let us know if we can close the issue.

@catmorales
Copy link

I deployed the tag 1.0.0-rc12 this morning in production. it seems not fixed on this tag.
I dont't have time to test it now .

@tdipisa
Copy link
Collaborator

tdipisa commented Jun 7, 2021

@offtherailz, any feedback?

@offtherailz
Copy link
Collaborator

#123 is fixed by rc13 . Please try the rc13.
See this:
https://github.com/georchestra/mapstore2-cadastrapp/releases
image

@catmorales
Copy link

Ok i'll try later. thank you @offtherailz

@MaelREBOUX
Copy link
Member Author

Hello. Sorry to be late.
Away on monday and now I'm busy by the geOcom since tuesday. I test tomorrow friday. Sure.

@MaelREBOUX
Copy link
Member Author

MaelREBOUX commented Jun 11, 2021

Hello.

OK : the bogue is fixed. It is sure. Congrats.

@tdipisa
Copy link
Collaborator

tdipisa commented Jun 11, 2021

@MaelREBOUX can you please open a new issue for the problem you described above? We will close this one if the related bug is effectively solved.

@MaelREBOUX
Copy link
Member Author

ok. I thinked about it.

@MaelREBOUX
Copy link
Member Author

=> #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants