Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to test that the column selection dialog closes #159

Closed
brianlove opened this issue Oct 30, 2023 · 1 comment
Closed

Figure out how to test that the column selection dialog closes #159

brianlove opened this issue Oct 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working testing view:list Issues specific to the list view of PARAT
Milestone

Comments

@brianlove
Copy link
Contributor

The column selection dialog test failed during #154 - despite various methods working perfectly on my local machine, they failed when run with GitHub Actions.

To temporarily resolve the issue I commented out the lines associated with the modal test in 5a863d5. Figure out how to check that the dialog has closed in a way that works both locally and on GitHub

@brianlove brianlove added the bug Something isn't working label Oct 30, 2023
@brianlove brianlove added this to the PARAT v2 milestone Oct 30, 2023
@brianlove brianlove self-assigned this Oct 30, 2023
@brianlove brianlove added view:list Issues specific to the list view of PARAT testing labels Nov 7, 2023
@brianlove
Copy link
Contributor Author

This was resolved in #156 (specifically cbb30a6):

      let dialogRemoved = waitForElementToBeRemoved(screen.getByRole('dialog'));
      await user.click(getByRole(dialog, 'button', { name: 'Apply' }));
      await dialogRemoved;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing view:list Issues specific to the list view of PARAT
Projects
None yet
Development

No branches or pull requests

1 participant