Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use USTAR read from GEOS instead of calculating from U10M and V10M #279

Open
wants to merge 3 commits into
base: dev/3.10.0
Choose a base branch
from

Conversation

yuanjianz
Copy link

@yuanjianz yuanjianz commented Jun 3, 2024

Name and Institution (Required)

Name: Yuanjian Zhang
Institution: WashU

Describe the update

Use USTAR friction velocity from meteorology instead of calculating from wind at 10m.
Comment out unused codes after this update but keep them following tradition.

Expected changes

Friction velocity is estimated to increase by 3 times. Dust emission is estimated to increase by 30 times, since dust emission is proportional to cube of friction velocity. Therefore, dust scaling factor needs to be recalculated. Following Meng, J.,et al, 2021, global annual dust emission for 2016 is scaled to 2000Tg.

Scaling factor
GEOS-IT: 2.6421e-05
MERRA-2: 3.8891e-05
GEOS-FP: 3.0655e-05

Related Github Issue

#278

@yantosca yantosca self-assigned this Jun 4, 2024
@yantosca yantosca added topic: Input Data Related to input/emissions data, or disk read/write operations topic: HEMCO Extensions Pertaining to HEMCO extensions category: Bug Fix Fixes a bug that was previously reported labels Jun 4, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanjianz. We can merge this pending updating the CHANGELOG.md file.

src/Extensions/hcox_dustdead_mod.F
- Commented out unused codes for shifting to use USTAR read from meteorology

CHANGELOG.md
- Added a description: Use USTAR from meteorology instead of calculating from reference 10m wind in DustDead extension
@yuanjianz yuanjianz requested a review from yantosca June 4, 2024 18:06
@yantosca yantosca changed the base branch from main to dev/3.10.0 June 4, 2024 18:14
@yantosca
Copy link
Contributor

yantosca commented Jun 4, 2024

Also, this PR will need to go into GC 14.5.0 / HEMCO 3.10.0, as this will change the fullchem benchmark simulation results. I've changed the target branch accordingly.

@yantosca yantosca added this to the 3.10.0 milestone Jun 4, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanjianz. I have a few minor comments, mostly about removing obsolete commented-out code.

src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Outdated Show resolved Hide resolved
src/Extensions/hcox_dustdead_mod.F Show resolved Hide resolved
@yantosca yantosca linked an issue Jul 16, 2024 that may be closed by this pull request
@yantosca
Copy link
Contributor

@lizziel: If we remove the code in the dust extension to compute USTAR (friction velocity), would this prove to be a problem for other models like CESM? I presume that is one of the meteorological variables available.

@lizziel
Copy link
Contributor

lizziel commented Jul 16, 2024

@yantosca: Removing the computation of USTAR in the dust extension is fine since we already have it available for use in drydep.

@yuanjianz yuanjianz requested a review from yantosca July 18, 2024 02:06
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanjianz. Good to merge. I'll start testing this now.

yantosca added a commit that referenced this pull request Jul 18, 2024
This merge brings in the updates for HEMCO PR #279 (Use USTAR read
from GEOS instead of calculating from U10M and V10M, by @yuanjianz)
atop the HEMCO 3.9.1 release.  This will be merged into the HEMCO
3.10.0 development stream after passing integration tests.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor

@yuanjianz @ltmurray: Would you know what the scaling factor would be for the GCAP2 meteorology?

@ltmurray
Copy link
Contributor

I don't know what the scaling factor would be for GCAP2, which is presently tuned given the existing parameterization. USTAR has been archived for GCAP2 though.

@yantosca
Copy link
Contributor

@yuanjianz @msulprizio @ltmurray @lizziel: We would need a companion PR to go along with this to update the setting of the $RUNDIR_DUSTDEAD_TF variable in the createRunDir.sh scripts for GCClassic and GCHP.

The current settings in run/GCClassic/createRunDir.sh are:

#----------------------------------------------------------------
# Horizontal resolution-dependent settings
#-----------------------------------------------------------------

if [[ ${met} = "ModelE2.1" ]]; then
    if [[ "$runid" == "E213f10aF40oQ40nudge" ]]; then
        if [[ "$grid_res" ==  "4x5" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.00474046'\n"
        elif [[ "$grid_res" == "2x25" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.00243979'\n"
        elif [[ "$grid_res" == "05x0625" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.00276896'\n"
        elif [[ "$grid_res" == "025x03125" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.00254319'\n"
	else
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='-999.0e0'\n"
  	fi
    else
        if [[ "$grid_res" ==  "4x5" ]]; then
            RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.03564873'\n"
        elif [[ "$grid_res" == "2x25" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.01050036'\n"
        elif [[ "$grid_res" == "05x0625" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.01340854'\n"
        elif [[ "$grid_res" == "025x03125" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='0.01066495'\n"
	else
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='-999.0e0'\n"
	fi
    fi
else
    RUNDIR_VARS+="RUNDIR_GISS_RES='not_used'\n"
    # Use GEOS-FP values as placeholders for GEOS-IT until parameters derived
    if [[ "x${sim_name}" == "xfullchem" || "x${sim_name}" == "xaerosol" ]]; then
	if [[ "x${met}" == "xgeosfp" && "x${grid_res}" == "x4x5" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='8.3286e-4'\n"
	elif [[ "x${met}" == "xgeosfp" && "x${grid_res}" == "x2x25" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='5.0416e-4'\n"
	elif [[ "x${met}" == "xmerra2" && "x${grid_res}" == "x4x5" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='7.8533e-4'\n"
	elif [[ "x${met}" == "xmerra2" && "x${grid_res}" == "x2x25" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='4.7586e-4'\n"
	elif [[ "x${met}" == "xgeosit" && "x${grid_res}" == "x4x5" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='8.3286e-4'\n"
	elif [[ "x${met}" == "xgeosit" && "x${grid_res}" == "x2x25" ]]; then
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='5.0416e-4'\n"
	else
	    RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='-999.0e0'\n"
	fi
    else
	RUNDIR_VARS+="RUNDIR_DUSTDEAD_TF='-999.0e0'\n"
    fi
fi

@yantosca
Copy link
Contributor

@yuanjianz @yidant: Would either of you be able to compute the dust scale factors (see above post)?

@yuanjianz
Copy link
Author

@yuanjianz @yidant: Would either of you be able to compute the dust scale factors (see above post)?

Hi @yantosca, sorry for the late response. I will try to work on this with Yidan.

@yidant, do we have GCAP2 archive at WashU?

@yantosca
Copy link
Contributor

yantosca commented Aug 1, 2024

Thanks @yidant & @yuanjianz. When you can get to this. Not immediately urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: HEMCO Extensions Pertaining to HEMCO extensions topic: Input Data Related to input/emissions data, or disk read/write operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DustDead extension ignores USTAR read from meteorology
4 participants