Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show failed transactions in transaction history #1140

Closed
bonomat opened this issue Aug 22, 2023 · 3 comments · Fixed by #1111
Closed

Show failed transactions in transaction history #1140

bonomat opened this issue Aug 22, 2023 · 3 comments · Fixed by #1111
Assignees
@Restioson

Comments

@bonomat
Copy link
Contributor

bonomat commented Aug 22, 2023

It looks like we are not showing failed off-chain transactions in the wallet. It would be good to see them.
@klochowicz
Copy link
Contributor

we do store them in the DB, so it should be a relatively easy one.

@Restioson
Copy link
Contributor

Seems related-ish to the ongoing work in #1111 & #1103. Happy to look at this after those unless someone gets to it first - no reason it can't be done in parallel imo

@Restioson Restioson self-assigned this Aug 25, 2023
@Restioson Restioson mentioned this issue Aug 25, 2023
Merged
17 tasks
@Restioson
Copy link
Contributor

Restioson commented Aug 25, 2023 •
edited
Loading

Just going to roll this into #1111. Although it's becoming a bit large now, I'd like to use the other infrastructure I implemented there for this

Restioson added a commit that referenced this issue Aug 25, 2023
@Restioson
feat: display failed payments
3892963 
fixes #1140
Restioson added a commit that referenced this issue Sep 4, 2023
@Restioson
feat: display failed payments
90eedd0 
fixes #1140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Restioson Restioson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Model more transaction history details get10101/10101
3 participants
@bonomat @Restioson @klochowicz