Add transaction details to transactions in wallet history

[holzeis]

Upon clicking a transaction one should see some details to the transaction. There are different types of transactions for which a details view is required.

• On chain transaction (potentially add a link to mempool)
• Off-chain transaction (payment or received)
  • Invoice description (moved from Add invoice title into wallet history #886)
• Position transaction (open and close)
• JIT Channel opening fee (potentially add a link to the funding transaction on mempool)
• Order matching fee

Figma mock:

https://www.figma.com/file/Sr3SfZ46sZstKjSwftmTtc/10101-v1-(incl-bitcoin.design)?type=design&node-id=7375%3A45885&mode=design&t=tFOk1Qr2JvlNIaBY-1

E.g. like this

Screen.Recording.2023-08-04.at.3.05.02.pm.mov

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[Restioson]

Note; #1054 partially addresses this but some more modelling work is required to show everything in the detail requested here

[Restioson]

With reference to the 'fee' row in the lightning payment example - is it not the case that lightning fees are per-channel and not per-transaction?

[holzeis]

With reference to the 'fee' row in the lightning payment example - is it not the case that lightning fees are per-channel and not per-transaction?

You are paying fees for outgoing transactions. The amount of fees is defined through the route (channels) you are using.

[Restioson]

With reference to the 'fee' row in the lightning payment example - is it not the case that lightning fees are per-channel and not per-transaction?

You are paying fees for outgoing transactions. The amount of fees is defined through the route (channels) you are using.

Ah, I see, thanks! So they are 'per-channel' insofar as the channel defines the fee, but the fee is paid upon every payment too?

[Restioson]

Do we want to model other timestamps than just the time we 'first learned' about this payment? E.g invoice creation timestamp

[Restioson]

With #1213, we will model all information required to fulfill this ticket. Now, onto prettifying it as per the Figma :) I will start on that tomorrow! 🎉

[Restioson]

Nit on figma: "you sent -1000" sats would imply that you received 1000 sats, wouldn't it? Maybe we can convey this in a different way?

[Restioson]

Nit on figma: "you sent -1000" sats would imply that you received 1000 sats, wouldn't it? Maybe we can convey this in a different way?

Thought: we could have outgoing transactions have red amount text and incoming have green?