Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bc-payment component to accept preimage instead of paid boolean #162

Open
rolznz opened this issue Dec 20, 2023 · 0 comments
Open

Change bc-payment component to accept preimage instead of paid boolean #162

rolznz opened this issue Dec 20, 2023 · 0 comments
Assignees
@rolznz
Labels
v4

Comments

@rolznz
Copy link
Collaborator

rolznz commented Dec 20, 2023

bc:onpaid is currently fired in multiple places.

This can be fixed if we pass the preimage to bc-send-payment instead of a paid boolean - then the bc-send-payment component can listen and fire the event for both WebLN and external payments.
@rolznz rolznz added the v4 label Dec 20, 2023
@rolznz rolznz self-assigned this Dec 20, 2023
@rolznz rolznz mentioned this issue Dec 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolznz rolznz

Labels
v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolznz