Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #182

Open
rolznz opened this issue Jan 5, 2024 · 8 comments
Open

Improve accessibility #182

rolznz opened this issue Jan 5, 2024 · 8 comments
Labels
good first issue Good for newcomers

Comments

@rolznz
Copy link
Collaborator

rolznz commented Jan 5, 2024

Tabbing / Keyboard access should work in all places. Some elements (like the button below) should be focused by default.

image

@rolznz rolznz added the good first issue Good for newcomers label Jan 5, 2024
@harith-hacky03
Copy link

Can you briefly describe the problem? I am ready to fix it

@rolznz
Copy link
Collaborator Author

rolznz commented Jan 8, 2024

Hi @harith-hacky03 this is a general task about keyboard accessibility throughout the library. I don't believe we can easily use Bitcoin Connect without a mouse right now for example. Some good information is here: https://usability.yale.edu/web-accessibility/articles/focus-keyboard-operability

@harith-hacky03
Copy link

@rolznz You need specificed action to happen when enter is pressed in keyboard right?

@rolznz
Copy link
Collaborator Author

rolznz commented Jan 8, 2024

@harith-hacky03 no. This is about accessibility. Maybe you could find a different issue if you would like to contribute.

@itstomekk
Copy link

Small reminder: there is a bounty for solving this issue!
I have posted it across multiple bounty platforms today, maybe someone will pick it up!

Bitcoin Connect is an embeddable, open-source JavaScript library maintained by Alby that allows websites to easily integrate Bitcoin and Lightning functionalities. It provides a modal widget for user interactions, enabling seamless onboarding and transactions.

Currently, the Bitcoin Connect modal widget requires a mouse for navigation and interaction, limiting its accessibility. By improving keyboard accessibility, we aim to make the library more inclusive and user-friendly for all users, including those with disabilities who rely on keyboard navigation.

💰 Bounty: 75,000 sats

💰 Alby's team & community support


🔗 Links:


💡 Please Remember:

  • 💡 Let the world know if you start working on this issue
  • 💡 Work on a feature branch or a forked repository
  • 💡 Submit a pull request with a detailed description of your changes
  • 💡 Follow basic coding standards and leave helpful comments
  • 💡 Test the modal widget's keyboard accessibility across multiple browsers and devices

♿ #ACCESSIBILITY #OPENNESS #DECENTRALIZATION

💙 Thank you for your contributions and making Bitcoin more accessible and user-friendly for everyone!

@harith-hacky03
Copy link

I am ready to fix it. Can you assign me please?

@rolznz
Copy link
Collaborator Author

rolznz commented Oct 23, 2024

@harith-hacky03 normally I do not assign issues to external contributors because there is no guarantee they will do it.

If you are interested, could you make a pull request?

@chebizarro
Copy link

Hey there, I've made an initial PR (#259) with mostly minor changes which enable both keyboard navigation and screen reader feedback. There's still some testing to be done and a few niggling issues with default buttons, but I'd appreciate if you could give me some feedback if I'm on the right path.

chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Oct 30, 2024
chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Oct 30, 2024
chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Nov 1, 2024
Base element accessibilty integrations

add accessibility options to components

Accessibilty changes internal

Accessibilty additions to components

last (?) changes for Improve accessibility getAlby#182

more aria additions
chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Nov 1, 2024
chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Nov 2, 2024
chebizarro added a commit to chebizarro/bitcoin-connect that referenced this issue Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants