Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using product name from command call doesn't work #5

Open
bgturner opened this issue Jan 21, 2021 · 1 comment
Open

Using product name from command call doesn't work #5

bgturner opened this issue Jan 21, 2021 · 1 comment

Comments

@bgturner
Copy link
Contributor

When running in non-interactive mode, for example, like this:

npx create-local-addon "My Product Name" directory-name

The productname argument isn't correctly parsed, with the second word of the string being interpreted as the directory name. See this screenshot for more details:

image

Note: Running the command in interactive mode (ie, when create-local-addon prompts you for productname and directoryname) does work.

@ethan309
Copy link
Contributor

That is really odd. I don't seem to get that issue on my end with the same steps. A check of the package.json confirms the directory and package are named correctly, too. Could it be a quote issue — like using directional quotation marks instead of standard/straight quotes? I do not believe I tested it with these variations, but it was just a random thought.

I have included my output below:

Screen Shot 2021-01-25 at 17 08 40

(I also tried running npx create-local-addon "My directory-name Name" directory-name-next just to see if the directory name being included in the name would somehow trip it up, but it worked fine.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants