Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Googlefonts #99

Open
RoundAboutWEB opened this issue Nov 17, 2022 · 7 comments
Open

Deactivate Googlefonts #99

RoundAboutWEB opened this issue Nov 17, 2022 · 7 comments

Comments

@RoundAboutWEB
Copy link

The "Learn2" theme is great, but it uses Google fonts, which makes the pages warnable.

How can the fonts be replaced/changed?

@sennewood
Copy link

My Firefox console doesn't show any connnection to a google server if that is your concern.
I'm using the docker variant of Grav if that is important.

@RoundAboutWEB
Copy link
Author

The problem will be with the theme "Learn2" (and some other). With the theme "Quark" everything will be fine.

@sennewood
Copy link

I'm using Learn2.

@RoundAboutWEB
Copy link
Author

Then you have changed something, because in the original fonts from Google are included:

grafik
File: user/themes/learn2/scss/theme/_fonts.scss

@sennewood
Copy link

The docker variant uses the libfreetype6 package: https://github.com/getgrav/docker-grav/blob/master/Dockerfile#L12

Maybe the fonts that needs to be loaded are included there? I honestly don't know, but since I didn't change anything regarding fonts I guess it has something to do with docker.

In any case it would help if more people respond to this issue :)

@eauchat
Copy link

eauchat commented Apr 5, 2024

I'm also interested in fixing this issue. It would be easy to provide the fonts locally. Or at least to give the option to do so.
Are you interested in a PR to address this issue? If so, I can write one.

Which approach would you prefer?

  • Just locally provide the font.
  • Give the option to: use google fonts or locally provide the font

@eauchat
Copy link

eauchat commented Apr 9, 2024

For the record, this theme is based on learn2 with a few improvements, one of which being that in removes google fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants