Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test setup #76

Open
carolynvs opened this issue Mar 4, 2022 · 0 comments
Open

Fix integration test setup #76

carolynvs opened this issue Mar 4, 2022 · 0 comments
Labels
2 - 🍕 Pizza should be eaten daily meta Things necessary to make this project run day to day

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 4, 2022

The integration tests has a hack right now where I deploy to the cluster, and then remove the controller so that the controller that is run by ginkgo doesn't collide with the deployed one and they both trigger when CRDs change. The deploy to the cluster is needed so that the CRDs are defined.

We should clean this up to not be such a hack (if for no other reason than it's slow). Some options are

  • use EnvTest instead of pointing ginkgo at an existing cluster
  • make a new kind cluster and only deploy the CRDs to it, leaving the dev cluster alone
  • have the operator only respond to events in a specified set of namespaces, ignoring ginkgo, so that we can just reuse the dev cluster
@carolynvs carolynvs mentioned this issue Mar 4, 2022
2 tasks
@carolynvs carolynvs added 1 - 🍫 Eat chocolate _after_ emergency donuts meta Things necessary to make this project run day to day labels Mar 4, 2022
@carolynvs carolynvs added 2 - 🍕 Pizza should be eaten daily and removed 1 - 🍫 Eat chocolate _after_ emergency donuts labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - 🍕 Pizza should be eaten daily meta Things necessary to make this project run day to day
Projects
None yet
Development

No branches or pull requests

1 participant