Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft does not correctly push multi arch images #541

Closed
Dav1dde opened this issue Jun 14, 2024 · 2 comments · Fixed by #556
Closed

Craft does not correctly push multi arch images #541

Dav1dde opened this issue Jun 14, 2024 · 2 comments · Fixed by #556

Comments

@Dav1dde
Copy link
Member

Dav1dde commented Jun 14, 2024

Environment

Running in Relay CI

Steps to Reproduce

Relay has a craft config which pushes docker containers. The source container is a multi arch container, the pushed container is not.

Expected Result

Craft should copy the multi arch container correctly.

Actual Result

The container is for a single arch. See also: getsentry/relay#3731

@BYK
Copy link
Member

BYK commented Jun 14, 2024

Sounds like we need a platforms config option for the docker target?

@Dav1dde
Copy link
Member Author

Dav1dde commented Jun 17, 2024

The problem with multiarch images is, you need to build the manifest once and cant incrementally push single archs.
Which means a platforms option is most likely not going to work.

In Relay CI we use regctl to move/copy multiarch images, this would be a simple option and could be gated behind a multiarch: true option, to not always require the dependeny.

The alternative I believe is to rebuild the multiarch manifest with docker buildx imagetools, which still seems to be very experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants