Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Discover Icon #3323

Open
JonPurvis opened this issue Sep 12, 2024 · 2 comments
Open

Missing Discover Icon #3323

JonPurvis opened this issue Sep 12, 2024 · 2 comments

Comments

@JonPurvis
Copy link

Self-Hosted Version

24.8.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.29.2

Steps to Reproduce

  1. Go to Dashboard
  2. Look at Discover Link in menu
  3. You should see a dot instead of an icon

I'm running on an Errors Only Sentry instance, not sure if that has any bearing.

Expected Result

In previous versions of Sentry, this is a telescope.

Actual Result

Image

Event ID

No response

@hubertdeng123
Copy link
Member

Thanks for reporting this! I believe this regression was introduced when we reworked the sidebar for Sentry

@aldy505
Copy link
Collaborator

aldy505 commented Sep 17, 2024

Just dug around. This is not a bug, see this line:

https://github.com/getsentry/sentry/blob/fa5c96d58debe2db4f3b1c8896f6944988d73904/static/app/components/sidebar/index.tsx#L243

Compared to the previous change that has <IconTelescope> component on it:

https://github.com/getsentry/sentry/blob/ccb3c648d0d065bfe84840d1956fb0a9f5ab3544/static/app/components/sidebar/index.tsx#L236

It's intended, but it'd surely be nicer if it's a telescope icon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Development

No branches or pull requests

3 participants