Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated crash reports: regular and WatchdogTermination #3207

Closed
kean opened this issue Aug 4, 2023 · 10 comments
Closed

Duplicated crash reports: regular and WatchdogTermination #3207

kean opened this issue Aug 4, 2023 · 10 comments

Comments

@kean
Copy link

kean commented Aug 4, 2023

Platform

iOS

Installed

CocoaPods

Version

8.9.2

Steps to Reproduce

In some scenarios, but not all, a single crash gets reported twice:

  • Once with an actual stacktrace
  • Once as an arbitrary WatchdogTermination

Expected Result

A crash results in a single even on Sentry. The crash rate is accurate.

Actual Result

The reported crash rate is inaccurate.

Occasion #1

Screenshot 2023-08-04 at 16 46 27 (1)

Occasion #2

image

Are you willing to submit a PR?

No response

@kean kean changed the title A single crash gets reported twice: once as an arbitrary WatchdogTermination Duplicated crash reports: regular and WatchdogTermination Aug 4, 2023
@kean
Copy link
Author

kean commented Aug 4, 2023

The main issue is that you can no longer accurately tell the real app's crash rate.

It seems there is already logic that should take care of the duplicates, but it doesn't seem to work every time.

  // The app crashed on the previous run. No Watchdog Termination.
  if (self.crashAdapter.crashedLastLaunch) {
    return NO;
  }

I checked one of the events from the screenshots I provided, and they contain identical breadcrumbs and timestamps.

@kahest
Copy link
Member

kahest commented Aug 7, 2023

Hi @kean, thanks for the report! We'll investigate. Please note that due to current vacations and holidays we may be slower to response.

@brustolin
Copy link
Contributor

Hello @kean. Is this a React Native project?

@kean
Copy link
Author

kean commented Aug 14, 2023

Hey, @brustolin. Yes, parts of it are, and I think both of these crashes happened in the RN part.

@brustolin
Copy link
Contributor

@krystofwoldrich do you have any idea what may cause this? Can you take a look?

@krystofwoldrich
Copy link
Member

The WatchDog issue is created based on a heuristic, are you or some library call exit(0) when the fatal error happens?

Is it the WordPress-iOS app that you linked the issue to? Are you able to reproduce it locally?

@kahest
Copy link
Member

kahest commented Nov 22, 2023

@kean could you provide more information and ideally answer above questions? Does it still occur?

@kean
Copy link
Author

kean commented Nov 27, 2023

The WatchDog issue is created based on a heuristic, are you or some library call exit(0) when the fatal error happens?

The crashes I originally reported were all coming the React Native part of the app.

it the wordpress-mobile/WordPress-iOS#20989 app that you linked the issue to? Are you able to reproduce it locally?

Yes, that's the correct repo, but I don't have a way to reproduce it.

This issue is currently much less of a concern as we managed to bring the overall number of the WatchdogTermination events significantly down. We suspect that disabling Sentry's app hang monitoring was the main reason why we saw the reduction, but it's hard to verify as there were many other changes that could've contributed to it.

@philipphofmann
Copy link
Member

as we managed to bring the overall number of the WatchdogTermination events significantly down.

@kean, what did you do to achieve this?

We suspect that disabling Sentry's app hang monitoring was the main reason why we saw the reduction

Disabling app hang monitoring only stops the SDK from reporting app hangs, but the app hang tracker still runs to avoid tracking app hangs that get killed as watchdog terminations. I would be surprised if that would be the main reason.

@getsantry
Copy link

getsantry bot commented Dec 21, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 21, 2023
@getsantry getsantry bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants