Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thirdPartyErrorIntegration should take behavior, not behaviour #13482

Closed
szokeasaurusrex opened this issue Aug 27, 2024 · 2 comments
Closed

thirdPartyErrorIntegration should take behavior, not behaviour #13482

szokeasaurusrex opened this issue Aug 27, 2024 · 2 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Aug 27, 2024

Description

The behavior of the thirdPartyErrorIntegration is currently defined by a parameter spelled behaviour, which is the British English spelling of the American English word "behavior" (without a "u").

Since Sentry prefers to use American English spelling in our documentation, and hence, also in public-facing APIs, we should change the name of this parameter to behavior. We can keep behaviour around as a deprecated alias to behavior for backwards-compatibility.

After correcting the spelling, we also need to update the example on this docs page to use the corrected spelling.

@lforst
Copy link
Member

lforst commented Aug 27, 2024

Hi, I messed this up but we'll likely not change it as all it does is increase bundle size with basically 0 user gain.

@lforst lforst closed this as completed Aug 27, 2024
@szokeasaurusrex
Copy link
Member Author

Fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants